test: use node:test in test-assert-async #55068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
anonrig
reviewed
Sep 22, 2024
avivkeller
reviewed
Sep 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55068 +/- ##
==========================================
+ Coverage 88.23% 88.24% +0.01%
==========================================
Files 652 651 -1
Lines 183911 183877 -34
Branches 35858 35852 -6
==========================================
- Hits 162271 162268 -3
+ Misses 14916 14894 -22
+ Partials 6724 6715 -9 |
jasnell
commented
Sep 23, 2024
Co-authored-by: Aviv Keller <[email protected]>
Co-authored-by: Mohammed Keyvanzadeh <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
requested changes
Sep 27, 2024
There was a problem hiding this comment.
I would like to see an official TSC vote/decision on this which is not made for Cloudflare/workerd interests. It is like we go to another project and start making changes to their tests (with all the drawbacks that this might have for that project) so that it is easier for us to use their tests. That seems silly to me.
|
Very well. Nevermind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More general cleanup and structuring of tests