Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-tls-junk-closes-server #55089

Merged
merged 3 commits into from
Sep 25, 2024
Merged

test: fix test-tls-junk-closes-server #55089

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9472340
test: fix test-tls-junk-closes-server
mhdawson Sep 23, 2024
0f549f4
Update test/parallel/test-tls-junk-closes-server.js
mhdawson Sep 24, 2024
ff25b99
Update test/parallel/test-tls-junk-closes-server.js
mhdawson Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions test/parallel/test-tls-junk-closes-server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,22 @@ const server = tls.createServer(options, common.mustNotCall());
server.listen(0, common.mustCall(function() {
const c = net.createConnection(this.address().port);

c.on('data', function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit that can be ignored: replace with c.resume().

// We must consume all data sent by the server. Otherwise the
// end event will not be sent and the test will hang.
// For example, when compiled with OpenSSL32 we see the
// following response '15 03 03 00 02 02 16' which
// decodes as a fatal (0x02) TLS error alert number 22 (0x16),
// which corresponds to TLS1_AD_RECORD_OVERFLOW which matches
// the error we see if NODE_DEBUG is turned on.
// Some earlier OpenSSL versions did not seem to send a response
// but the TLS spec seems to indicate there should be one
// https://datatracker.ietf.org/doc/html/rfc8446#page-85
// and error handling seems to have been re-written/improved
// in OpenSSL32. Consuming the data allows the test to pass
// either way.
});

c.on('connect', common.mustCall(function() {
c.write('blah\nblah\nblah\n');
}));
Expand Down
Loading