test: add unexpected behavior repro test #55095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
Thanks for bringing this up, I realised this bug as well, and I forgot to create an issue for it 😄 |
avivkeller
added
the
test_runner
avivkeller
reviewed
Sep 24, 2024
Comment on lines
+62
to
+70
| if (testRuns.length === 1) { | ||
| firstRunCompleted.resolve(); | ||
| } else if (testRuns.length === 2) { | ||
| secondRunCompleted.resolve(); | ||
| } else if (testRuns.length === 3) { | ||
| thirdRunCompleted.resolve(); | ||
| } else if (testRuns.length === 4) { | ||
| fourthRunCompleted.resolve(); | ||
| } |
There was a problem hiding this comment.
Yep no problem at all 🚀
avivkeller
added
wip
|
I'm closing this since another PR it's proposing a fix 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this PR as a draft since I have not had the time to fix the issue yet.
This test highlights what I believe to be an issue related to file watcher owners.
Basically, given a specific series of updates to files under watch, the link between the test file and its dependency is being lost.
@cjihrig @jakecastelli, FYI