zlib: deprecate classes usage without new
#55718
Merged
+42
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
avivkeller
added
semver-major
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
avivkeller
reviewed
Nov 4, 2024
anonrig
force-pushed
the
yagiz/deprecate-zlib
branch
from
f77caf7 to
dbfed33
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55718 +/- ##
==========================================
- Coverage 87.97% 87.96% -0.01%
==========================================
Files 656 656
Lines 188391 188403 +12
Branches 35976 35975 -1
==========================================
- Hits 165732 165728 -4
- Misses 15835 15847 +12
- Partials 6824 6828 +4
|
avivkeller
reviewed
Nov 4, 2024
anonrig
force-pushed
the
yagiz/deprecate-zlib
branch
from
dbfed33 to
245e4f3
Compare
jasnell
reviewed
Nov 23, 2024
jasnell
approved these changes
Nov 23, 2024
anonrig
force-pushed
the
yagiz/deprecate-zlib
branch
from
245e4f3 to
d93282c
Compare
anonrig
force-pushed
the
yagiz/deprecate-zlib
branch
from
d93282c to
bc8cce0
Compare
|
cc @nodejs/tsc this requires an additional TSC approval to land. |
ronag
approved these changes
Nov 29, 2024
anonrig
added
the
commit-queue
jasnell
approved these changes
Nov 29, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4ee87b8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we documentation-only deprecated the usage without
newqualifier, we can make it runtime deprecated.