lib: resolve the issue of not adhering to the specified buffersize #55896
+41
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
|
@Ethan-Arrowood, please take a look at the PR when you have a chance. It should be ready for merge unless some any issues is found! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55896 +/- ##
==========================================
+ Coverage 88.00% 88.53% +0.53%
==========================================
Files 656 657 +1
Lines 188999 190413 +1414
Branches 35989 36554 +565
==========================================
+ Hits 166331 168589 +2258
+ Misses 15848 15007 -841
+ Partials 6820 6817 -3
|
Ethan-Arrowood
added
the
request-ci
|
Looking good. Have you tested it locally by running the relevant fs readdir and opendir recursive test files? I'm not really sure if this needs a unique test as you are more just improving an existing solution. I requested a CI run now and we'll see how this does. Thanks for the contribution! |
github-actions
bot
removed
the
request-ci
Yes, I've tested it. It should be good unless I missed something.
Agreed. I don't think we need a new test since, as you mentioned, nothing fundamentally new was added. |
Ethan-Arrowood
approved these changes
Nov 30, 2024
Ethan-Arrowood
added
the
commit-queue
|
Looks good to me, and CI is passing! Thank you, lets gets this merged. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55896 ✔ Done loading data for nodejs/node/pull/55896 ----------------------------------- PR info ------------------------------------ Title lib: resolve the issue of not adhering to the specified buffersize (#55896) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cu8code:55723 -> nodejs:main Labels fs, needs-ci Commits 1 - lib: resolve the issue of not adhering to the specified buffer size Committers 1 - cu8code <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55896 Refs: https://github.com/nodejs/node/issues/55764 Reviewed-By: Ethan Arrowood <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55896 Refs: https://github.com/nodejs/node/issues/55764 Reviewed-By: Ethan Arrowood <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 17 Nov 2024 17:27:03 GMT ✔ Approvals: 1 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/55896#pullrequestreview-2470703507 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-11-30T01:14:02Z: https://ci.nodejs.org/job/node-test-pull-request/63800/ - Querying data for job/node-test-pull-request/63800/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12093348479 |
|
Hm i thought the CI run succeeded. I'll see if a retry helps. |
Ethan-Arrowood
added
request-ci
github-actions
bot
removed
the
request-ci
We create a `queueHandler`, and in every iteration we execute the handlers in the `queueHandler` until we get a non-null result.
Ethan-Arrowood
added
the
commit-queue
Ethan-Arrowood
approved these changes
Dec 9, 2024
github-actions
bot
removed
the
request-ci
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55896 ✔ Done loading data for nodejs/node/pull/55896 ----------------------------------- PR info ------------------------------------ Title lib: resolve the issue of not adhering to the specified buffersize (#55896) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cu8code:55723 -> nodejs:main Labels fs, needs-ci Commits 1 - lib: resolve the issue of not adhering to the specified buffer size Committers 1 - cu8code <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55896 Refs: https://github.com/nodejs/node/issues/55764 Reviewed-By: Ethan Arrowood <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55896 Refs: https://github.com/nodejs/node/issues/55764 Reviewed-By: Ethan Arrowood <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 17 Nov 2024 17:27:03 GMT ✔ Approvals: 1 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/55896#pullrequestreview-2489049523 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-12-09T15:00:05Z: https://ci.nodejs.org/job/node-test-pull-request/63954/ - Querying data for job/node-test-pull-request/63954/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12241884962 |
|
Why did you close this? I think only flaky tests were failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #55764
We create a
queueHandler, and in every iteration we execute the handlers in thequeueHandleruntil we get a non-null result.