Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate tests to use node:test module for better test structure for worker test #56029

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mertcanaltin
Copy link
Member

This update refactors the test structure to use the node:test module, aiming to improve consistency and maintainability across the codebase.

this is part of a long pull request: #56024

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 27, 2024
@mertcanaltin mertcanaltin changed the title test: migrate tests to use node:test module for better test structure test: migrate tests to use node:test module for better test structure for worker test Nov 27, 2024
@mertcanaltin mertcanaltin requested a review from anonrig November 27, 2024 18:27
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (9029aec) to head (787c310).
Report is 179 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56029   +/-   ##
=======================================
  Coverage   87.95%   87.96%           
=======================================
  Files         656      656           
  Lines      188372   188372           
  Branches    35979    35979           
=======================================
+ Hits       165687   165704   +17     
+ Misses      15851    15839   -12     
+ Partials     6834     6829    -5     

see 20 files with indirect coverage changes

@mertcanaltin mertcanaltin added the blocked PRs that are blocked by other issues or PRs. label Dec 24, 2024
@mertcanaltin
Copy link
Member Author

#54796, #56027, #55716
I added a blocker tag because it is linked

lpinca

This comment was marked as outdated.

Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm blocking this because there is an approval now and as discussed in other places this is not an improvement in my opinion. I will remove the block once TSC officially decides that a mass refactor to node:test is good for the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants