Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate tests to use node:test module for better test structure for C Ares #56033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mertcanaltin
Copy link
Member

Updated c-ares tests to use the node:test module for improved structure and maintainability.

this is part of a long pull request: #56024

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 27, 2024
@mertcanaltin mertcanaltin changed the title test: migrate tests to use node:test module for better test structure test: migrate tests to use node:test module for better test structure for C Ares Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (9029aec) to head (226d249).
Report is 179 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56033   +/-   ##
=======================================
  Coverage   87.95%   87.96%           
=======================================
  Files         656      656           
  Lines      188372   188372           
  Branches    35979    35982    +3     
=======================================
+ Hits       165687   165702   +15     
+ Misses      15851    15834   -17     
- Partials     6834     6836    +2     

see 25 files with indirect coverage changes

@mertcanaltin mertcanaltin added the blocked PRs that are blocked by other issues or PRs. label Dec 24, 2024
@mertcanaltin
Copy link
Member Author

#54796, #56027, #55716
I added a blocker tag because it is linked

Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm blocking this because there is an approval now and as discussed in other places this is not an improvement in my opinion. I will remove the block once TSC officially decides that a mass refactor to node:test is good for the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants