-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert: make partialDeepStrictEqual work with urls and File prototypes #56231
Open
puskin94
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
puskin94:partial-deep-strict-equal-missing-cases
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
assert: make partialDeepStrictEqual work with urls and File prototypes #56231
puskin94
wants to merge
1
commit into
nodejs:main
from
puskin94:partial-deep-strict-equal-missing-cases
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
Issues and PRs related to the assert subsystem.
needs-ci
PRs that need a full CI run.
labels
Dec 11, 2024
BridgeAR
approved these changes
Dec 11, 2024
BridgeAR
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Dec 11, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56231 +/- ##
==========================================
+ Coverage 88.54% 88.56% +0.02%
==========================================
Files 657 657
Lines 189899 190663 +764
Branches 36465 36593 +128
==========================================
+ Hits 168140 168859 +719
- Misses 14966 14995 +29
- Partials 6793 6809 +16
|
tonivj5
reviewed
Dec 11, 2024
puskin94
force-pushed
the
partial-deep-strict-equal-missing-cases
branch
from
December 11, 2024 20:20
40e6cba
to
943cb6d
Compare
jasnell
approved these changes
Dec 12, 2024
meixg
approved these changes
Dec 18, 2024
Sorry I seem to have accidentally clicked it multiple times. |
puskin94
force-pushed
the
partial-deep-strict-equal-missing-cases
branch
from
December 25, 2024 21:58
943cb6d
to
6b649a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
assert
Issues and PRs related to the assert subsystem.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR should close the gap between
assert.deepStrictEqual
andassert.partialDeepStrictEqual
even more.Found a couple more cases that were not properly working:
Object.getPrototypeOf(File.prototype)
andBlob.prototype
new Float32Array([+0.0])
andnew Float32Array([-0.0])
were considered equal, which is not the case