Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify that WASM is trusted #56345

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

mcollina
Copy link
Member

This clarifies that WASM is trusted, too.

@mcollina mcollina requested a review from RafaelGSS December 23, 2024 10:41
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 23, 2024
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move that to the point number 3 The code it is asked to run?

node/SECURITY.md

Lines 114 to 117 in d1b8b5c

3. The code it is asked to run, including JavaScript and native code, even if
said code is dynamically loaded, e.g., all dependencies installed from the
npm registry.
The code run inherits all the privileges of the execution user.

Also, the subsystem should be doc:, not docs:

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina force-pushed the clarify-that-wasm-is-truested branch from ac86b0d to e4cca8c Compare December 24, 2024 08:59
Signed-off-by: Matteo Collina <[email protected]>
@@ -111,8 +111,8 @@ lead to a loss of confidentiality, integrity, or availability.
1. The developers and infrastructure that runs it.
2. The operating system that Node.js is running under and its configuration,
along with anything under control of the operating system.
3. The code it is asked to run, including JavaScript and native code, even if
said code is dynamically loaded, e.g., all dependencies installed from the
3. The code it is asked to run, including JavaScript, WASM and native code, even
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Oxford comma

Suggested change
3. The code it is asked to run, including JavaScript, WASM and native code, even
3. The code it is asked to run, including JavaScript, WASM, and native code, even

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 25, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 25, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/56345
✔  Done loading data for nodejs/node/pull/56345
----------------------------------- PR info ------------------------------------
Title      docs: clarify that WASM is trusted (#56345)
Author     Matteo Collina <[email protected]> (@mcollina)
Branch     mcollina:clarify-that-wasm-is-truested -> nodejs:main
Labels     doc, author ready
Commits    2
 - doc: clarify that WASM is trusted
 - fixup
Committers 1
 - Matteo Collina <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/56345
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56345
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 23 Dec 2024 10:41:22 GMT
   ✔  Approvals: 6
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/56345#pullrequestreview-2520769508
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/56345#pullrequestreview-2520784482
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/56345#pullrequestreview-2520941099
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/56345#pullrequestreview-2521093391
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/56345#pullrequestreview-2521135655
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/56345#pullrequestreview-2521816923
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 56345
From https://github.com/nodejs/node
 * branch                  refs/pull/56345/merge -> FETCH_HEAD
✔  Fetched commits as d00710dd8dcb..8ced8f4821f3
--------------------------------------------------------------------------------
[main 47c0b2b8d6] doc: clarify that WASM is trusted
 Author: Matteo Collina <[email protected]>
 Date: Mon Dec 23 11:40:47 2024 +0100
 1 file changed, 3 insertions(+), 3 deletions(-)
[main 0fd65aecb1] fixup
 Author: Matteo Collina <[email protected]>
 Date: Tue Dec 24 11:33:24 2024 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: clarify that WASM is trusted

Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #56345
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

[detached HEAD a9111ce812] doc: clarify that WASM is trusted
Author: Matteo Collina <[email protected]>
Date: Mon Dec 23 11:40:47 2024 +0100
1 file changed, 3 insertions(+), 3 deletions(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup

Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #56345
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

[detached HEAD 0a6dc084df] fixup
Author: Matteo Collina <[email protected]>
Date: Tue Dec 24 11:33:24 2024 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/12492304537

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7ca7531 into nodejs:main Dec 25, 2024
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7ca7531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants