Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add ts eval snapshots #56358

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marco-ippolito
Copy link
Member

Some light refactoring and printing error message from --eval with ts

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Dec 25, 2024
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.56%. Comparing base (da3f388) to head (0986177).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56358      +/-   ##
==========================================
+ Coverage   88.54%   88.56%   +0.01%     
==========================================
  Files         657      657              
  Lines      190655   190636      -19     
  Branches    36582    36585       +3     
==========================================
+ Hits       168824   168834      +10     
+ Misses      15008    14988      -20     
+ Partials     6823     6814       -9     
Files with missing lines Coverage Δ
lib/internal/process/execution.js 99.17% <100.00%> (+1.35%) ⬆️

... and 38 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants