Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: report loadingFinished until the response data is consumed #56372

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Dec 26, 2024

The Network.loadingFinished should be deferred until the response is
complete and the data is fully consumed. Also, report correct request
url with the specified port by retrieving the host from the request
headers. The timestamp in the network events should be monotonic
times.

Refs: #53946

@nodejs-github-bot nodejs-github-bot added inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Dec 26, 2024
The `Network.loadingFinished` should be deferred until the response is
complete and the data is fully consumed. Also, report correct request
url with the specified port by retrieving the host from the request
headers.
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 94.08284% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.54%. Comparing base (c94a9db) to head (1dec91e).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/inspector/network_http.js 94.69% 7 Missing ⚠️
lib/internal/inspector/network.js 90.32% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56372      +/-   ##
==========================================
- Coverage   88.55%   88.54%   -0.01%     
==========================================
  Files         657      659       +2     
  Lines      190658   190734      +76     
  Branches    36589    36600      +11     
==========================================
+ Hits       168837   168888      +51     
- Misses      15009    15022      +13     
- Partials     6812     6824      +12     
Files with missing lines Coverage Δ
lib/internal/inspector_network_tracking.js 100.00% <100.00%> (+6.66%) ⬆️
lib/internal/inspector/network.js 90.32% <90.32%> (ø)
lib/internal/inspector/network_http.js 94.69% <94.69%> (ø)

... and 45 files with indirect coverage changes

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 28, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants