Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: inspect: do not crash on Symbol function names #56572

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jan 12, 2025

See #56570 - this avoids a crash when a Function name is a Symbol.

@ljharb ljharb added the util Issues and PRs related to the built-in util module. label Jan 12, 2025
@ljharb ljharb requested a review from BridgeAR January 12, 2025 20:55
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 12, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 12, 2025

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (9230f22) to head (6932162).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56572      +/-   ##
==========================================
+ Coverage   89.17%   89.19%   +0.01%     
==========================================
  Files         662      662              
  Lines      191761   191762       +1     
  Branches    36905    36919      +14     
==========================================
+ Hits       171006   171038      +32     
+ Misses      13620    13567      -53     
- Partials     7135     7157      +22     
Files with missing lines Coverage Δ
lib/internal/util/inspect.js 99.95% <100.00%> (+0.04%) ⬆️

... and 25 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants