v20.19.3 proposal #58588
Open
v20.19.3 proposal #58588
+54,535
−40,274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29c0324 added a few test environments that are simply not working 20.x branch. Let's revert those changes that were unrelated, probably a result of a sloppy conflict resolution. PR-URL: #58351 Reviewed-By: Marco Ippolito <[email protected]>
PR-URL: #57994 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Edy Silva <[email protected]>
PR-URL: #57994 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Edy Silva <[email protected]>
If the buffer allocation fails due to insufficient memory, there is no point continue testing toString(). PR-URL: #58415 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
The test only cares about whether a size outside the range of the 32-bit signed integers works with Blob.prototype.slice(). If it fails due to allocation failure when the system does not have enough memory, the test should just be skipped. The test previously only skipped the test when the allocation failure happens during allocation of the buffer source, but it could also happen during Blob.prototype.slice(). PR-URL: #58414 Fixes: #57235 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Stefan Stojanovic <[email protected]>
This is the certdata.txt[0] from NSS 3.108. This is the version of NSS that shipped in Firefox 136.0 on 2025-03-04. Certificates added: - D-TRUST BR Root CA 2 2023 - D-TRUST EV Root CA 2 2023 Certificates removed: - SwissSign Silver CA - G2 [0] https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_108_RTM/lib/ckfw/builtins/certdata.txt PR-URL: #57381 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #55296 Reviewed-By: James M Snell <[email protected]>
The `out/Makefile` target in `Makefile` has an incomplete list of `.gyp` files for Node.js dependencies in `deps`, but also the ones that are listed are unconditional. If using any of the `--shared-*` configure options, it should be possible to still build Node.js if the corresponding directory under `deps` is removed. Convert the explicit list of dependency `*.gyp` files for the `out/Makefile` target to a glob. This will pick up any toplevel `.gyp` files for dependencies present in `deps`. PR-URL: #55789 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #55892 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jason Zhang <[email protected]>
PR-URL: #56142 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Signed-off-by: Matteo Collina <[email protected]> PR-URL: #56428 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Paolo Insogna <[email protected]>
PR-URL: #56764 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
PR-URL: #57265 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
PR-URL: #57384 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #57620 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Chemi Atlow <[email protected]>
This special case was missed in the previous changes to this file. Refs: #55514 Refs: #42923 Fixes: #57669 PR-URL: #57695 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]>
PR-URL: #57742 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #57785 Refs: #40121 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
increase the z-index of the header element to make sure that opened pickers from it (such as the node version picker) are on top of other content PR-URL: #57851 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Co-Authored-By: richardlau - Richard Lau <[email protected]> PR-URL: #58090 Refs: #57934 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
build
marco-ippolito
force-pushed
the
v20.19.3-proposal
branch
from
b00ffce to
75b2daa
Compare
marco-ippolito
added a commit
that referenced
this pull request
Jun 5, 2025
Notable changes: crypto: * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142 * update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381 deps: * update timezone to 2025b (Node.js GitHub Bot) #57857 doc: * stabilize util.styleText (Rafael Gonzaga) #56265 * add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102 PR-URL: #58588
marco-ippolito
force-pushed
the
v20.19.3-proposal
branch
from
172a0f5 to
fb7d05e
Compare
|
Dropped the commit and changed the release date to 2025-06-17 |
|
@nodejs/releasers asking for help on this release. I have no idea how to fix the test failing on rhel |
|
Let's bisect git bisect bad fb7d05e07cf211968a7a0db502f67861cc64d15f
git bisect good 14d228a5fff4621c472f654d00c1ae6c1ce751bchttps://ci.nodejs.org/job/node-test-commit-plinux/59465/ Bisecting [10fb49f] deps: update icu to 77.1 GOOD 🟢 Bisecting [d582954] src: remove unused variable in crypto_x509.cc GOOD 🟢 Bisecting [1521125] typings: fix Bisecting [8237346] test,crypto: update WebCryptoAPI WPT GOOD 🟢 Bisecting [3cf7cfb] test: update WPT for WebCryptoAPI to edd42c005c GOOD 🟢 Bisecting [b427ae4] meta: remove Bisecting [fb7d05e] 2025-06-17, Version 20.19.3 'Iron' (LTS) BAD 🔴 |
|
The release commit is the bad commit fb7d05e, it makes the test fail 🫤 |
|
I'm not able to think of how that change could affect SEA. It's just as surprising as the webcrypto WPT update that was being suspected earlier. Weird that this fails on just rhel8-ppc64le and not on rhel9-ppc64le. @nodejs/platform-ppc might know why. I suspect this is because of a platform limitation. Another way of debugging this would be to study the core dump if one is produced or run the SEA in a debugger and check the backtrace to know where the segmentation fault is happening. |
|
I agree this is a @nodejs/build specifically @nodejs/platform-ppc issue so not really much I can do about it |
|
It seems fine to just skip the test on rhel8+ppc, that's only a tier 2 platform and I doubt how many users would actually be affected by this. |
|
Technically
Is it ok to mark all these tests as skip? |
|
I'm also okay with marking these tests as skip on v20.x for rhel8-ppc64le because SEA is experimental. Also, arm64 is tier 1 on Linux and macOS but we are already skipping some tests on main - node/test/parallel/parallel.status Lines 57 to 60 in 214e4db |
|
I opened a PR to skip these tests PTAL #58761 |
|
I'm ok with skipping the tests since SEA is experimental and I believe that there is likely low usage on power systems at this point |
PR-URL: #58761 Refs: #58588 Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Notable changes: crypto: * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142 * update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381 deps: * update timezone to 2025b (Node.js GitHub Bot) #57857 doc: * add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102 PR-URL: #58588
marco-ippolito
force-pushed
the
v20.19.3-proposal
branch
from
fb7d05e to
76f8282
Compare
|
Finally a green CI 🥹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-06-23, Version 20.19.3 'Iron' (LTS), @marco-ippolito
Notable Changes
c535a3c483] - crypto: graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142af1dc63815] - crypto: update root certificates to NSS 3.108 (Node.js GitHub Bot) #5738101d63a4ddf] - deps: update timezone to 2025b (Node.js GitHub Bot) #57857b6daa344eb] - doc: add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102Commits
fc1fa7a357] - build: use FILE_OFFSET_BITS=64 esp. on 32-bit arch (RafaelGSS) #5809079e0812181] - build: use glob for dependencies of out/Makefile (Richard Lau) #55789f56e62851a] - crypto: allow length=0 for HKDF and PBKDF2 in SubtleCrypto.deriveBits (Filip Skokan) #55866c535a3c483] - crypto: graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #5614239925de8b1] - crypto: allow non-multiple of 8 in SubtleCrypto.deriveBits (Filip Skokan) #55296af1dc63815] - crypto: update root certificates to NSS 3.108 (Node.js GitHub Bot) #57381d09008add3] - deps: V8: cherry-pick 1a3ecc2483b2 (Michaël Zasso) #58342fd56652425] - deps: V8: cherry-pick 182d9c05e78b (Andrey Kosyakov) #58342447481e829] - deps: V8: cherry-pick third_party/zlib@646b7f569718 (Hans Wennborg) #58342eb447168df] - deps: update simdutf to 6.4.2 (Node.js GitHub Bot) #5785501d63a4ddf] - deps: update timezone to 2025b (Node.js GitHub Bot) #5785710fb49f2a9] - deps: update icu to 77.1 (Node.js GitHub Bot) #57455f1dc7d0205] - deps: update corepack to 0.32.0 (Node.js GitHub Bot) #572657a2e64bb8a] - deps: update simdutf to 6.4.0 (Node.js GitHub Bot) #56764e80669be0d] - doc: mention reports should align with Node.js CoC (Rafael Gonzaga) #576077b2c0bc92e] - doc: add gurgunday as triager (Gürgün Dayıoğlu) #57594791e4879de] - doc: document REPL custom eval arguments (Dario Piotrowicz) #576902917f09876] - doc: improved fetch docs (Alessandro Miliucci) #57296d940b15843] - doc: clarifyunhandledRejectionevents behaviors in process doc (Dario Piotrowicz) #5765471c664fab7] - doc: update position type to integer | null in fs (Yukihiro Hasegawa) #577450c0fbfa9c6] - doc: add missing v0.x changelog entries (Antoine du Hamel) #57779e99462c9fc] - doc: correct deprecation type ofassert.CallTracker(René) #57997c7e92696ef] - doc: add returns for https.get (Eng Zer Jun) #58025ccc42b69ce] - doc: fix env variable name inutil.styleText(Antoine du Hamel) #58072b6daa344eb] - doc: add dario-piotrowicz to collaborators (Dario Piotrowicz) #58102e5d6a3df16] - doc: fixAsyncLocalStorageexample response changes after node v18 (Naor Tedgi (Abu Emma)) #57969f006411998] - doc: fix typo of filezlib.md(yusheng chen) #580935193735df4] - doc: add missing options.signal to readlinePromises.createInterface() (Jimmy Leung) #55456fd44af730f] - doc: fix misaligned options in vm.compileFunction() (Jimmy Leung) #581450fdcc0ddcd] - doc: add ambassaor message (Brian Muenzenmeyer) #576005ca9616bd3] - doc: increase z-index of header element (Dario Piotrowicz) #5785181342d10f0] - doc: fix deprecation type forDEP0148(Livia Medeiros) #57785776becfe01] - doc: remove mention of--requirenot supporting ES modules (Huáng Jùnliàng) #576203140a8f133] - doc: add missingdeprecatedbadges infs.md(Yukihiro Hasegawa) #57384441ce24ae3] - doc: deprecate passing invalid types infs.existsSync(Carlos Espa) #558920556f54544] - http: correctly translate HTTP method (Paolo Insogna) #52701c2c6d2b035] - http: be more generational GC friendly (ywave620) #56767cdf3fa241c] - http2: skip writeHead if stream is closed (Shima Ryuhei) #57686bbd5aec785] - http2: fix graceful session close (Kushagra Pandey) #57808b427ae4f34] - meta: removebuild-windows.yml(Aviv Keller) #5466249e624f554] - os: fix netmask format check condition in getCIDR function (Wiyeong Seo) #57324d582954434] - src: remove unused variable in crypto_x509.cc (Michaël Zasso) #57754234a505e96] - src: allow embedder customization of OOMErrorHandler (Shelley Vohr) #57325c0252cd380] - src: fix -Wunreachable-code-return in node_sea (Shelley Vohr) #57664fcd1622fc1] - src: fix kill signal 0 on Windows (Stefan Stojanovic) #57695850192b06b] - test: skip broken sea on rhel8 (Marco Ippolito) #587613cf7cfb695] - test: update WPT for WebCryptoAPI to edd42c005c (Node.js GitHub Bot) #57365f57765bdcf] - test: mark test-without-async-context-frame flaky on windows (James M Snell) #56753275ea8e7ef] - test: force GC in test-file-write-stream4 (Luigi Pinca) #57930da6a13c338] - test: deflake test-http2-options-max-headers-block-length (Luigi Pinca) #5795956fce6691e] - test: prevent extraneous HOSTNAME substitution in test-runner-output (René) #58076c9c0be5596] - test: update expected error message for macOS (Antoine du Hamel) #577423cbf5f93d2] - test: fix missing edge case in test-blob-slice-with-large-size (Joyee Cheung) #58414bffd4ec379] - test: skip in test-buffer-tostring-rangeerror on allocation failure (Joyee Cheung) #584158237346fb7] - test,crypto: update WebCryptoAPI WPT (Filip Skokan) #54593b90c4ab937] - tools: remove unusedosx-pkg-postinstall.sh(Antoine du Hamel) #57667414013dcfb] - tools: edit create-release-proposal workflow to handle pr body length (Elves Vieira) #578417c449ed6b3] - tools: fix tarball testing directory (Marco Ippolito) #57994d164dc2d38] - tools: update sccache version to v0.10.0 (Marco Ippolito) #57994debd3c2cc0] - tools: disable failing test envs intest-linuxCI (Antoine du Hamel) #58351152112505a] - typings: fixImportModuleDynamicallyCallbackreturn type (Chengzhong Wu) #57160363bf744ab] - worker: flush stdout and stderr on exit (Matteo Collina) #56428