-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
module: convert schema-only core module on convertCJSFilenameToURL
#58612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
136b877
to
817052d
Compare
From the issue description I don’t think its the validation that should be changed - it should be the URL that gets passed into the hooks that should be corrected (it should’ve been node:sea instead of sea, looks like somewhere in the CJS loader the conversion is missed since internally we use filenames and ids everywhere and only convert them to URLs when being passed into hooks). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58612 +/- ##
==========================================
+ Coverage 90.12% 90.14% +0.01%
==========================================
Files 637 637
Lines 188121 188125 +4
Branches 36892 36905 +13
==========================================
+ Hits 169552 169593 +41
+ Misses 11313 11260 -53
- Partials 7256 7272 +16
🚀 New features to boost your workflow:
|
22850d8
to
a49f57b
Compare
Yeah, I read the code and think the issue should be in |
validateLoad
convertCJSFilenameToURL
convertCJSFilenameToURL
convertCJSFilenameToURL
08ec6cc
to
d2b8035
Compare
2f30145
to
9bcd67a
Compare
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/15542291850 |
#58612 (comment) @himself65 in case you missed it |
1bec580
to
a79df89
Compare
Co-authored-by: Joyee Cheung <[email protected]>
628e6d7
to
4b27d6a
Compare
Fixes: #58607