doc: fix stream.md section order
#58811
Merged
+38
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
himself65
approved these changes
Jun 24, 2025
Ethan-Arrowood
approved these changes
Jun 24, 2025
lpinca
approved these changes
Jun 24, 2025
aduh95
added
author ready
jasnell
approved these changes
Jun 25, 2025
For some reason, `stream.isErrored` and `stream.isReadable` sections were in between `stream.Readable` static methods sections.
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58811 ✔ Done loading data for nodejs/node/pull/58811 ----------------------------------- PR info ------------------------------------ Title doc: fix `stream.md` section order (#58811) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:stream-doc-order -> nodejs:main Labels doc, stream, author ready Commits 1 - doc: fix `stream.md` section order Committers 1 - Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58811 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58811 Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - doc: fix `stream.md` section order ℹ This PR was created on Tue, 24 Jun 2025 07:22:31 GMT ✔ Approvals: 4 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/58811#pullrequestreview-2953026348 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/58811#pullrequestreview-2954001430 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58811#pullrequestreview-2955143413 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58811#pullrequestreview-2958739243 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15895692396 |
|
Landed in dbd24b1 |
aduh95
removed
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason,
stream.isErroredandstream.isReadablesections were in betweenstream.Readablestatic methods sections.