Skip to content

fs: correct error message when FileHandle is transferred #59156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

himself65
Copy link
Member

Fixes: #59155

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jul 22, 2025
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (29626f8) to head (fc5cb21).
⚠️ Report is 71 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #59156   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files         648      648           
  Lines      190975   190988   +13     
  Branches    37440    37436    -4     
=======================================
+ Hits       171955   171969   +14     
- Misses      11659    11666    +7     
+ Partials     7361     7353    -8     
Files with missing lines Coverage Δ
lib/internal/fs/promises.js 98.14% <100.00%> (+<0.01%) ⬆️

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 22, 2025
@nodejs-github-bot
Copy link
Collaborator

@himself65 himself65 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 22, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@himself65
Copy link
Member Author

#56794 (comment)

@aduh95
Copy link
Contributor

aduh95 commented Jul 28, 2025

@himself65 please do not restart full CI run

If there are Jenkins CI failures unrelated to the change in the pull request,
try "Resume Build". It is in the left navigation of the relevant
`node-test-pull-request` job. It will preserve all the green results from the
current job but re-run everything else. Start a fresh CI by pressing "Retry"
if more than seven days have elapsed since the original failing CI as the
compiled binaries for the Windows and ARM platforms are only kept for seven days.

@himself65
Copy link
Member Author

himself65 commented Jul 28, 2025

retry and rebuild are the different thing? ok i didn't read the guide carefully 😢

@aduh95
Copy link
Contributor

aduh95 commented Jul 28, 2025

retry and rebuild are the different thing? ok i didn't read the guide carefully 😢

Yes, and Resume Build is yet another thing, and what you meant to use in case of flakiness unrelated to the PR

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@himself65 himself65 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2025
@nodejs-github-bot nodejs-github-bot merged commit a93da0a into nodejs:main Jul 29, 2025
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a93da0a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs.FileHandler emit misleading error after transfer
7 participants