Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: some component cleanups and design fixes #6046

Merged
merged 7 commits into from
Oct 25, 2023
Merged

meta: some component cleanups and design fixes #6046

merged 7 commits into from
Oct 25, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Oct 24, 2023

Description

This PR does a few component normalisation and design fixes:

  • Fixes the LanguageDropdown as it was slightly deviating from Figmas
  • Updated Props from LanguageDropdown to reflect on agreements (see feat(themeToggle): introduce #6007)
  • Updated some components that were exporting types and use ComponentProps instead
  • Normalised Component imports to use absolute imports @
  • Updated a few components to only import formattedMessage from intl Hook

Validation

All Storybooks should be the same, besides the LanguageDropdown one and all Storybooks should be working.

@ovflowd ovflowd requested a review from a team as a code owner October 24, 2023 18:16
@vercel
Copy link

vercel bot commented Oct 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 1:51pm

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 24, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2023 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
 94.61% (281/297) 76.81% (53/69) 93.22% (55/59)

Unit Test Report

Tests Skipped Failures Errors Time
29 0 💤 0 ❌ 0 🔥 8.442s ⏱️

@ovflowd ovflowd changed the title chore: simplified button meta: some component cleanups and design fixes Oct 24, 2023
@AugustinMauroy
Copy link
Member

Normalised Component imports to use absolute imports @

Don't my to specify on Callab guide how imports are made.

shanpriyan
shanpriyan approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ovflowd
Copy link
Member Author

ovflowd commented Oct 25, 2023

Normalised Component imports to use absolute imports @

Don't my to specify on Callab guide how imports are made.

What?

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Oct 25, 2023
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 25, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 25, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Oct 25, 2023

cc @nodejs/nodejs-website can we fast-track this as these are simply changes?

canerakdas
canerakdas approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@canerakdas canerakdas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have only a tiny comment, we need to update this line to avoid misunderstandings;

https://github.com/nodejs/nodejs.org/blob/main/COLLABORATOR_GUIDE.md?plain=1#L290

@AugustinMauroy
Copy link
Member

I mean we need to update the collaborateor guide

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 25, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 25, 2023
@ovflowd ovflowd mentioned this pull request Oct 25, 2023
Merged
5 tasks
@ovflowd ovflowd added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 2defb6e Oct 25, 2023
10 checks passed
@ovflowd ovflowd deleted the fix/some-design-and-component-fixes branch October 25, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanpriyan shanpriyan shanpriyan approved these changes

@canerakdas canerakdas canerakdas approved these changes

Assignees
No one assigned
Labels
fast-track Fast Tracking PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ovflowd @AugustinMauroy @canerakdas @shanpriyan