-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lighthouse CI #6047
Merged
Merged
Add Lighthouse CI #6047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add lighthouse preview
add more than one url
remove unnecessary condition
increase vercel timeout
update pull-request comment
add more than one url a different way
remove unused config
use same comment on final result
comment todo
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Oct 25, 2023
ovflowd
reviewed
Oct 25, 2023
ovflowd
reviewed
Oct 25, 2023
ovflowd
reviewed
Oct 25, 2023
chore: simplify code, add tests
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Oct 27, 2023
araujogui
approved these changes
Oct 27, 2023
ovflowd
reviewed
Oct 27, 2023
ovflowd
reviewed
Oct 27, 2023
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Oct 28, 2023
ovflowd
approved these changes
Oct 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fantastic work here, @bmuenzenmeyer! This will definitely allow us to measure performance changes during development!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds our desired Lighthouse CI workflow
Validation
bmuenzenmeyer#64
Related Issues
closes #5492
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.