Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lighthouse CI #6047

Merged
merged 59 commits into from
Oct 28, 2023
Merged

Add Lighthouse CI #6047

merged 59 commits into from
Oct 28, 2023

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Oct 25, 2023

Description

Adds our desired Lighthouse CI workflow

  • persistent, updated comment
  • results in comment, not status
  • table results
    • by URL, with link to preview
    • category breakdown, with stoplight colors
    • scores driven off of vercel infra, not a local or in memory run
    • with link to full report

Validation

image

bmuenzenmeyer#64

Related Issues

closes #5492

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

add more than one url a different way
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
95.3% (325/341) 77.63% (59/76) 94.28% (66/70)

Unit Test Report

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 9.04s ⏱️

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fantastic work here, @bmuenzenmeyer! This will definitely allow us to measure performance changes during development!

@ovflowd ovflowd enabled auto-merge October 28, 2023 09:21
@ovflowd ovflowd added this pull request to the merge queue Oct 28, 2023
Merged via the queue into nodejs:main with commit 1e2f96a Oct 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Lighthouse-CI
3 participants