Add shas to workflow images #6090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
requesting fast-track because this change is trivial |
bmuenzenmeyer
commented
Nov 2, 2023
github-actions
bot
removed
the
github_actions:pull-request
Unit Test Coverage Report
Unit Test Report
|
MattIPv4
approved these changes
Nov 2, 2023
ovflowd
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completing the work started during hacktoberfest - the dependency update work always highlights that we are inconsistent in our approach here.
The work also revealed some risk in chromaui/action in that there is no discernable tag or url to view the sha, only a moment in time that is
lateston their repositories. I have added on to an issue report that is is unusual and make for a difficult time maintaining intentionality as a customer.We could look into something like https://github.com/zgosalvez/github-actions-ensure-sha-pinned-actions to enforce this - but I don't yet know if that is overkill.
Validation
All images the same, but more readable.
Related Issues
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing.