chore: remove engines field from package.json

[MrHBS]

Is this required?

Description

Validation

Related Issues

Check List

• I have read the Contributing Guidelines and made commit messages that follow the guideline.
• I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
• I have run npx turbo format to ensure the code follows the style guide.
• I have run npx turbo test to check if all tests are passing.
• I've covered new added functionality with unit tests if necessary.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nodejs-org	❌ Failed (Inspect)			Nov 2, 2023 7:22pm

[AugustinMauroy]

LGTM thanks for you first contribution 🎉

[github-actions]

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	95.41% (333/349)	77.21% (61/79)	93.05% (67/72)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
42	0 💤	0 ❌	0 🔥	10.12s ⏱️

[AugustinMauroy]

@ovflowd have you access to see what is the problème with Vercel ?

[ovflowd]

Why you dont check Vercel Status Website? :)

[MrHBS]

Looks like Vercel is having issues https://www.vercel-status.com/

[AugustinMauroy]

Why you dont check Vercel Status Website? :)

oh I just discovered that 😅

and my first idea is "what why it's fail? Vercel take care about this ?"

[ljharb]

I'm confused; why would you want to remove this? the engines field makes it explicit what versions of node the project can run on.

[ovflowd]

I'm confused; why would you want to remove this? the engines field makes it explicit what versions of node the project can run on.

Now I noticed what this PR is about. Wholeheartedly agree with @ljharb. We added the engines field exactly because we only support said versions.

[MrHBS]

@ljharb Doesn’t it only work when you have engine-strict set to true in your .npmrc?

[ljharb]

@MrHBS it gives you a warning regardless, and either way it's human documentation. No package.json should ever omit engines, ever.

[MrHBS]

Well I saw this project lacked the flag in their .npmrc so I found this field redundant. Closing this since you all happen to disagree.

[MrHBS]

Btw, I could be mistaken, shouldn’t it be >=18 without the v?

[ljharb]

Both are valid; see npx semver -c '>= v18' vs npx semver -c '>= 18'

[MrHBS]

@ljharb Since it is simple enough, would you want me to open a PR to add the engine-strict flag?

[ljharb]

That will break installs if anything in the graph has mis-set its engines field, so no. It’s best to treat the engines field as advisory for your graph.