-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPDX identifier to LICENSE #6141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Muenzenmeyer <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
approved these changes
Nov 24, 2023
ljharb
approved these changes
Nov 24, 2023
AugustinMauroy
approved these changes
Nov 24, 2023
UlisesGascon
approved these changes
Nov 24, 2023
fast-tracking - trivial but important fix |
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Nov 24, 2023
Lighthouse Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a SPDX identifier to the nodejs.org repo.
This has a number of benefits.
GitHub will display the license info more succinctly for users. This helps users understand our license faster (though it matters less than a consumable library)
Check this out from one of my other projects.
GitHub will show the license file in the sidebar.
The OpenSSF scorecard will be able to identify the license. There is an open "issue" about this right now.
https://github.com/nodejs/nodejs.org/security/code-scanning/58 (I know not everyone may be able to see that)
If this works out, I will consider contributing it to nodejs/node for the same reasons.
Validation
N/A
Related Issues
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.