Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SPDX identifier to LICENSE #6141

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Add SPDX identifier to LICENSE #6141

merged 1 commit into from
Nov 24, 2023

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Nov 24, 2023

Description

Adds a SPDX identifier to the nodejs.org repo.

This has a number of benefits.

GitHub will display the license info more succinctly for users. This helps users understand our license faster (though it matters less than a consumable library)

Check this out from one of my other projects.

image

GitHub will show the license file in the sidebar.

image

The OpenSSF scorecard will be able to identify the license. There is an open "issue" about this right now.

https://github.com/nodejs/nodejs.org/security/code-scanning/58 (I know not everyone may be able to see that)


If this works out, I will consider contributing it to nodejs/node for the same reasons.

Validation

N/A

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner November 24, 2023 14:19
Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 24, 2023 2:19pm

@bmuenzenmeyer bmuenzenmeyer added the fast-track Fast Tracking PRs label Nov 24, 2023
@bmuenzenmeyer
Copy link
Collaborator Author

fast-tracking - trivial but important fix

Copy link
Contributor

github-actions bot commented Nov 24, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 93 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/blog 🟢 98 🟢 95 🟢 92 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
90.59% (366/404) 77.77% (91/117) 89.04% (65/73)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 5.687s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Nov 24, 2023
Merged via the queue into main with commit 3ae1ff5 Nov 24, 2023
21 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the bmuenzenmeyer-patch-1 branch November 24, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants