Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: we should invalidate data over time #6153

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Nov 30, 2023

Description

This PR provides a hot-fix for invalidating static-generated data (such as node releases) over time.

It also makes swift adjustments to fix the fetch error when doing vercel build && vercel deploy --prebuilt due to the NEXT_DATA variable being set to localhost.

It also allows the [page] dynamic segment to always be regenerated (the Markdown context) over time.

Validation

Cache should invalidate, requests should work.

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Nov 30, 2023
@ovflowd ovflowd requested review from a team as code owners November 30, 2023 18:35
Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 6:37pm

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 94 🟢 97 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 92 🟢 92 🔗
/en/blog 🟢 100 🟢 95 🟢 92 🟢 92 🔗

@ovflowd
Copy link
Member Author

ovflowd commented Nov 30, 2023

cc @nodejs/nodejs-website requesting fast-track as this is an important bug fix.

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 94%
90.17% (367/407) 77.04% (94/122) 89.18% (66/74)

Unit Test Report

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 4.587s ⏱️

@ovflowd ovflowd merged commit 80af3e1 into main Nov 30, 2023
22 checks passed
@ovflowd ovflowd deleted the fix/invalidate-data-correctly branch November 30, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant