Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: whitespace between the main content and progressive sidebar #7271

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: whitespace between the main content and progressive sidebar #7271

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47760db
Fix whitespace between the main content and progressive sidebar
amyy2 Nov 21, 2024
421bd90
Remove .DS_Store files
amyy2 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .DS_Store
View file
Open in desktop
amyy2 marked this conversation as resolved.
Show resolved Hide resolved
Binary file not shown.
Binary file added apps/.DS_Store
View file
Open in desktop
amyy2 marked this conversation as resolved.
Show resolved Hide resolved
Binary file not shown.
9 changes: 7 additions & 2 deletions apps/site/layouts/layouts.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
.articleLayout {
@apply max-w-8xl
sm:grid-areas-[sidebar_main,sidebar_footer]
lg:grid-areas-[sidebar_main_metabar,sidebar_footer_metabar]
lg:grid-areas-[sidebar_._metabar,sidebar_main_metabar,sidebar_footer_metabar]
mx-auto
block
w-full
Expand Down Expand Up @@ -42,7 +42,11 @@
p-4
motion-safe:scroll-smooth
sm:bg-fixed
sm:p-12;
sm:p-12
lg:sticky
lg:bottom-[4rem]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lg:bottom-[4rem]
lg:bottom-16

In the default Tailwind spacing scale, 16 is equivalent to 4rem

lg:h-max
lg:min-h-[calc(100vh_-_4rem)];
}

> *:last-child {
Expand All @@ -61,6 +65,7 @@
sticky
bottom-0
flex
h-[4rem]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
h-[4rem]
h-16

Similarly, you can use h-16

w-full
flex-col
items-center
Expand Down