Introduce notify-on-force-push workflow #7322
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
| Before: <https://github.com/${{ github.repository }}/commit/${{ github.event.before }}|${{ github.event.before }}> | ||
| After: <https://github.com/${{ github.repository }}/commit/${{ github.event.after }}|${{ github.event.after }}> | ||
| SLACK_USERNAME: nodejs-bot | ||
| SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} |
There was a problem hiding this comment.
I need help understanding how to generate this. Will ask in Slack
IMO, no, we have a wait-before-merge policy. In my opinion, merge force push should only be used when it's absolutely necessary to restore/fix something. |
| - name: Slack Notification | ||
| uses: rtCamp/action-slack-notify@c33737706dea87cd7784c687dadc9adf1be59990 # 2.3.2 | ||
| env: | ||
| SLACK_COLOR: '#DE512A' |
There was a problem hiding this comment.
| SLACK_COLOR: '#DE512A' | |
| SLACK_COLOR: '#DE512A' # orange |
There was a problem hiding this comment.
I purposely kept it the same as the nodejs/node repo - but 🤷
There was a problem hiding this comment.
yeah I just propose to explain which colors is behind this exa
|
Also in the rest markdown documents there is no specific mention of |
Correct - sorry if my language was not clear. I agree there are circumstances that make it necessary / expedient / useful to have force push. |
If I am understanding your concern, the webhook secret has the channel baked in to it, that's why you don't see it on the action config at all. |
|
switching this to DRAFT to make it clear the webhook secret is NOT yet in place |
Oops, I didn't make myself clear, I was talking about adding a reference to the slack channel in the documentation to explain that part of the discussion takes place there. For example on the readme or contributing.md |
Description
Adopting the workflow from nodejs/node - https://github.com/rtCamp/action-slack-notify - which will be useful as we add more users with
writeaccess to the repo as part of CODEOWNERS work, AND it introduces accountability for existing users.Should anyone be able to force push at all? I think the answer remains yes, but I want more visibility to it.
Validation
Post-merge, force pushes will send a Slack message to #nodejs-website
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.