Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos in wasm mjs example #7333

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

stanley2058
Copy link
Contributor

@stanley2058 stanley2058 commented Dec 17, 2024

Description

Fix a typo in the WASM mjs example to match the cjs one.

Validation

The current one:
image

This PR:
image

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@stanley2058 stanley2058 requested a review from a team as a code owner December 17, 2024 12:01
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 17, 2024 0:02am

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 89%
88.6% (583/658) 70.28% (175/249) 92.43% (110/119)

Unit Test Report

Tests Skipped Failures Errors Time
137 0 💤 0 ❌ 0 🔥 4.831s ⏱️

@mikeesto mikeesto added this pull request to the merge queue Dec 19, 2024
Merged via the queue into nodejs:main with commit 169cbdc Dec 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants