Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable spanish #7334

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Enable spanish #7334

merged 1 commit into from
Dec 18, 2024

Conversation

bmuenzenmeyer
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer commented Dec 17, 2024

Description

I failed to push a commit within #7332

Validation

https://nodejs-org-git-enable-spanish-openjs.vercel.app/es

Related Issues

In theory this can be used to test #7324 - but the branch name is not a match.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot bot review requested due to automatic review settings December 17, 2024 17:09
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner December 17, 2024 17:09

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 17, 2024 5:09pm

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 89%
88.6% (583/658) 70.28% (175/249) 92.43% (110/119)

Unit Test Report

Tests Skipped Failures Errors Time
137 0 💤 0 ❌ 0 🔥 5.125s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Dec 18, 2024

I believe we can fast track this?

@AugustinMauroy AugustinMauroy added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 23508d5 Dec 18, 2024
16 checks passed
@AugustinMauroy AugustinMauroy deleted the enable-spanish branch December 18, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants