Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asynchronous-flow-control.md #7336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mrwasii
Copy link

@mrwasii mrwasii commented Dec 18, 2024

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@mrwasii mrwasii requested a review from a team as a code owner December 18, 2024 11:57
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 18, 2024 11:58am

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I think this code block is just meant to be an illustrative example of what "callback hell" looks like. This change adds a lot of lines for not a lot of benefit in the context of the page. Does that make sense?

@bmuenzenmeyer
Copy link
Collaborator

bmuenzenmeyer commented Dec 20, 2024

I'm 👎 on this change - the intent of the content, IMO, is brief explanation of what we mean. Expanding the code to be more complete actually hurts that comprehension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants