Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta(codeowners): add typescript to learn section #7338

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

AugustinMauroy
Copy link
Member

Description

Adding typescript team to code owners. In goal to have someone to review the content and maintain it.
Also it's was discussed on meeting there are any objections.

Validation

CODEOWNERS should be valid

Related Issues

Related to #7292

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

@Copilot Copilot bot review requested due to automatic review settings December 18, 2024 20:37
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner December 18, 2024 20:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • CODEOWNERS: Language not supported
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 18, 2024 8:37pm

@AugustinMauroy
Copy link
Member Author

BTW I think we need to add them to repo write access ?

@bmuenzenmeyer
Copy link
Collaborator

BTW I think we need to add them to repo write access ?

correct, and done

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 89%
88.6% (583/658) 70.28% (175/249) 92.43% (110/119)

Unit Test Report

Tests Skipped Failures Errors Time
137 0 💤 0 ❌ 0 🔥 5.286s ⏱️

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit d41673c Dec 20, 2024
16 checks passed
@bmuenzenmeyer bmuenzenmeyer deleted the meta-typescript-codeowner branch December 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants