Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: IBM AIX Icon added #7356

Merged
merged 3 commits into from
Dec 25, 2024
Merged

feat: IBM AIX Icon added #7356

merged 3 commits into from
Dec 25, 2024

Conversation

canerakdas
Copy link
Member

Description

IBM AIX icon added to operating system icons

Validation

The icon should appear correctly on the download page (in OS select) and in the Storybook in the preview

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@canerakdas canerakdas requested a review from a team as a code owner December 24, 2024 22:44
Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 24, 2024 10:45pm

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.38% (592/655) 75.43% (172/228) 94.26% (115/122)

Unit Test Report

Tests Skipped Failures Errors Time
132 0 💤 0 ❌ 0 🔥 5.213s ⏱️

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ovflowd
Copy link
Member

ovflowd commented Dec 25, 2024

I'm fast tracking this PR!

@ovflowd ovflowd added this pull request to the merge queue Dec 25, 2024
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Dec 25, 2024
Merged via the queue into nodejs:main with commit 077e07e Dec 25, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants