Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download: restore preamble in download snippets #7360

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Dec 27, 2024

See https://nodejs-hj4exhlax-openjs.vercel.app/en/download/package-manager (preview from #7323) for the previous version

See #7351 (comment) for removal context

Description

Restores package manager setup instructions, as they were prior to #7351.

Validation

this PR's preview will confirm that.

Related Issues

See above.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@ljharb ljharb requested review from ovflowd and Copilot December 27, 2024 06:29
@ljharb ljharb requested a review from a team as a code owner December 27, 2024 06:29

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (5)
  • apps/site/snippets/en/download/brew.bash: Language not supported
  • apps/site/snippets/en/download/choco.bash: Language not supported
  • apps/site/snippets/en/download/docker.bash: Language not supported
  • apps/site/snippets/en/download/fnm.bash: Language not supported
  • apps/site/snippets/en/download/nvm.bash: Language not supported
Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 27, 2024 6:30am

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 86%
84.47% (631/747) 65.37% (185/283) 83.91% (120/143)

Unit Test Report

Tests Skipped Failures Errors Time
137 0 💤 0 ❌ 0 🔥 5.138s ⏱️

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-tracking this PR! Note that some of these will completely change on #7357

@ovflowd ovflowd added this pull request to the merge queue Dec 27, 2024
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Dec 27, 2024
Merged via the queue into nodejs:main with commit 68c3996 Dec 27, 2024
23 checks passed
@ljharb ljharb deleted the fix-install-steps branch December 27, 2024 18:45
@ljharb
Copy link
Member Author

ljharb commented Dec 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants