Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compatibility engine should run even on initial state #7366

Merged
merged 6 commits into from
Dec 28, 2024
Merged

fix: compatibility engine should run even on initial state #7366

merged 6 commits into from
Dec 28, 2024

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Dec 28, 2024

This PR prevents the compatibility engine to simply say it is compatible when on a loading state.

@ovflowd ovflowd requested a review from a team as a code owner December 28, 2024 17:48
@vercel Vercel
Copy link

vercel bot commented Dec 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 28, 2024 6:07pm

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 28, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 75 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟠 82 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 28, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
 84.08% (597/710) 65.12% (183/281) 82.7% (110/133)

Unit Test Report

Tests Skipped Failures Errors Time
124 0 💤 0 ❌ 0 🔥 4.881s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
ljharb
ljharb approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addresses the issue with AIX being available on initial load, but it'd be good to have tests :-) (here or in a followup)

@ovflowd ovflowd added fast-track Fast Tracking PRs github_actions:pull-request Trigger Pull Request Checks labels Dec 28, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
@ovflowd
Copy link
Member Author

ovflowd commented Dec 28, 2024

This addresses the issue with AIX being available on initial load, but it'd be good to have tests :-) (here or in a followup)

Indeed. I'm unfortunately out of bandwidth right now for tests (which could have captured this) -- maybe our test guru @AugustinMauroy can help us here 🙏

@ovflowd
Copy link
Member Author

ovflowd commented Dec 28, 2024

cc @nodejs/nodejs-website fast-tracking as a hot fix 🙏

@ovflowd ovflowd merged commit c8e604f into main Dec 28, 2024
23 checks passed
@ovflowd ovflowd deleted the hotfix/disabled-items-during-loading-state branch December 28, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
fast-track Fast Tracking PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ovflowd @ljharb