-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Minor changes on download page #7367
Merged
Merged
+21
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
reviewed
Dec 28, 2024
ovflowd
reviewed
Dec 28, 2024
ovflowd
reviewed
Dec 28, 2024
ovflowd
reviewed
Dec 28, 2024
apps/site/components/Downloads/Release/PrebuiltDownloadButtons.tsx
Outdated
Show resolved
Hide resolved
ovflowd
reviewed
Dec 28, 2024
AugustinMauroy
approved these changes
Dec 28, 2024
ovflowd
approved these changes
Dec 28, 2024
github-actions
bot
removed
the
github_actions:pull-request
Trigger Pull Request Checks
label
Dec 28, 2024
Lighthouse Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On small resolutions, download buttons have been changed to be full-width
The minimum width of the upload method causes shifting for cases where
ARM64
comes after the skeleton, the minimum width has been adjustedFor macOS and Linux, since the
CodeBox
height is higher after the skeleton, it causes a layout shift the minimum height adjustedA different layout was used instead of the home layout for the Not Found page
Since the blog post is not an external link, the component used here has been changed
Validation
The skeleton on the download page in the preview should not cause a layout shift.
The layout on the Not Found page should also look correct
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.