Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Minor changes on download page #7367

Merged
merged 6 commits into from
Dec 28, 2024

Conversation

canerakdas
Copy link
Member

@canerakdas canerakdas commented Dec 28, 2024

Description

On small resolutions, download buttons have been changed to be full-width

The minimum width of the upload method causes shifting for cases where ARM64 comes after the skeleton, the minimum width has been adjusted

For macOS and Linux, since the CodeBox height is higher after the skeleton, it causes a layout shift the minimum height adjusted

A different layout was used instead of the home layout for the Not Found page

Since the blog post is not an external link, the component used here has been changed

Validation

The skeleton on the download page in the preview should not cause a layout shift.

The layout on the Not Found page should also look correct

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@canerakdas canerakdas requested a review from a team as a code owner December 28, 2024 18:49
Copy link

vercel bot commented Dec 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 28, 2024 8:29pm

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 28, 2024
Copy link
Contributor

github-actions bot commented Dec 28, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 85 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
84.08% (597/710) 65.12% (183/281) 82.7% (110/133)

Unit Test Report

Tests Skipped Failures Errors Time
124 0 💤 0 ❌ 0 🔥 4.869s ⏱️

@ovflowd ovflowd enabled auto-merge December 28, 2024 21:35
@ovflowd ovflowd added this pull request to the merge queue Dec 28, 2024
Merged via the queue into nodejs:main with commit 53591f9 Dec 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants