-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Devbox as commumity download option #7370
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: @mootoday <[email protected]>
Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: @mootoday <[email protected]>
Hey @mootoday thank you for your contribution! A quick survey, how was the DevEx (Developer Experience) implementing this new download option? We are still adding guides here: #7365 Was it easy? Trivial? Did you like the way we structured the code so you can add new Download options? Did you enjoy the snippet system on dedicated files? Thank you! |
Lighthouse Results
|
I started by creating a new entry in The docs updates PR is great and will improve DevEx a lot. I'd say it took me ten minutes to add the necessary code and see the changes in the local preview. The Looking at the PR now, I notice it requires changes to 5 directories. This is me being a backseat driver contributing to this repo for the first time, so take it with a grain of salt please 😊. It'd be nice to have a directory per download option where most of the relevant code lives. That way, adding a new option means copy & paste an existing directory and update the code. All in all, straightforward and no hurdles. |
Co-authored-by: Augustin Mauroy <[email protected]> Signed-off-by: Mike <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Description
This PR adds Devbox (github.com/jetify-com/devbox) as a community download option for Node.js.
Validation
Related Issues
N/A, I opened this in response to https://x.com/mootoday/status/1873199929864405280.
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.I've covered new added functionality with unit tests if necessary.