Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add more unit tests #7371

Merged
merged 2 commits into from
Jan 3, 2025
Merged

chore: add more unit tests #7371

merged 2 commits into from
Jan 3, 2025

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Dec 29, 2024 •
edited
Loading

This PR adds more unit tests covering functionality on apps/site/util, apps/site/reducers and apps/site/providers

@ovflowd ovflowd requested a review from a team as a code owner December 29, 2024 12:17
@vercel Vercel
Copy link

vercel bot commented Dec 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 29, 2024 0:23am

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 29, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 29, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 78 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 29, 2024 •
edited
Loading

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 88%
 87.1% (736/845) 72.13% (233/323) 86.33% (139/161)

Unit Test Report

Tests Skipped Failures Errors Time
185 0 💤 0 ❌ 0 🔥 5.491s ⏱️

@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Dec 29, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Dec 29, 2024
AugustinMauroy
AugustinMauroy approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but when you have some const or other thing and and expect you need to add breakline to separate both thing

@ovflowd
Copy link
Member Author

ovflowd commented Dec 29, 2024

Mostly LGTM, but when you have some const or other thing and and expect you need to add breakline to separate both thing

Can you reference what file you're talking about? Most of this was generated by Copilot. I checked the tests and seem good enough, are you talking about code styling?

@ovflowd ovflowd added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit e20a801 Jan 3, 2025
16 checks passed
@ovflowd ovflowd deleted the chore/add-more-unit-tests branch January 3, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ovflowd @AugustinMauroy