-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64-glibc-217 recipe #83
Conversation
515d7b4
to
70c83f3
Compare
70c83f3
to
4b0fcba
Compare
have you been able to (roughly) test this in some form to verify that it ~builds? |
@rvagg as I also just added to the PR description, I tried to build the Docker image on a ARM CPU running on GCP and it compiled without any issues, so as far as I can see this should work. I also ran the resulting node binary and entered the REPL. So the initial testing was ok. Obviously I've not been able to test on the hardware that the Node.js build group uses, so I'm not sure if my usage of |
Btw, when building Node.js, I'm getting the warning As far as I understand, this is a general "issue" that also affects the official builds, and hence shouldn't be something to worry about for this specific PR |
Since we're building this on an x64 machine, I suspect we might need some arm64 arch libraries in the toolchain dependencies for this? I imagine those come automatically if you're running arm native. |
Ah ok, I actually thought that it was running on ARM hardware based on what I saw in the I'll see what I can do to update this PR accordingly. |
We've got an internal repo based on the x64-glibc-217 recipe and I attempted to add arm64 support in a similar fashion as this PR. The changes are nearly identical but when attempting to build on our x64 GHA workers we get:
Just as @rvagg suspected it seems like some additional libs are needed to build on x64. I tried adding |
this PR doesn't work in the slightest. you don't even set the cross compilers please close this PR |
Create a copy of the
x64-glibc-217
recipe (introduced in PR #69) targetingarm64
instead ofx64
.I tried to build the Docker image on a ARM CPU running on GCP and it compiled without any issues, so as far as I can see this should work