Merge pull request #140 from CliffS/master

A few minor tweaks
nodemailer · Mar 15, 2020 · 93e42a1 · 93e42a1
2 parents 14c2435 + b87cbf7
commit 93e42a1
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/lib/smtp-connection.js b/lib/smtp-connection.js
@@ -247,6 +247,10 @@ class SMTPConnection extends EventEmitter {
                 .join(' ');
         }
 
+        if (code >= 400) {
+          this.session.error = payload;
+        }
+
         if (this._socket && this._socket.writable) {
             this._socket.write(payload + '\r\n');
             this._server.logger.debug(
@@ -346,6 +350,7 @@ class SMTPConnection extends EventEmitter {
             return;
         }
 
+        err.remote = this.remoteAddress
         this._server.logger.error(
             {
                 err,

diff --git a/lib/smtp-server.js b/lib/smtp-server.js
@@ -170,6 +170,11 @@ class SMTPServer extends EventEmitter {
                     connection.close();
                 });
             }
+            if (typeof callback === 'function') {
+              const realCallback = callback;
+              callback = null;
+              return realCallback();
+            }
         }, timeout);
     }
 

diff --git a/test/smtp-stream-test.js b/test/smtp-stream-test.js
@@ -1,5 +1,5 @@
 /* eslint no-unused-expressions:0, prefer-arrow-callback: 0 */
-/* globals beforeEach, describe, it */
+/* globals describe, it */
 
 'use strict';