Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zms 86 mailboxes #501

Merged
merged 14 commits into from
Sep 21, 2023
Merged

Zms 86 mailboxes #501

merged 14 commits into from
Sep 21, 2023

Conversation

NickOvt
Copy link
Contributor

@NickOvt NickOvt commented Sep 20, 2023

  • tests for POST /users/{user}/mailboxes
  • tests for GET /users/{user}/mailboxes
  • tests for GET /users/:user/mailboxes/:mailbox
  • tests for PUT /users/:user/mailboxes/:mailbox
  • tests for DELETE /users/:user/mailboxes/:mailbox

@NickOvt NickOvt requested a review from andris9 September 20, 2023 06:59
test/api/mailboxes-test.js Outdated Show resolved Hide resolved
test.txt Outdated Show resolved Hide resolved
@andris9
Copy link
Member

andris9 commented Sep 20, 2023

Does the in progress and TODO mean that you will be updating this PR with additional tests or is it done and you add these tests later or in a separate PR?

@NickOvt
Copy link
Contributor Author

NickOvt commented Sep 20, 2023

Yes, will add tests for other 3 endpoints under this PR as well, just different commits.

test/api/mailboxes-test.js Outdated Show resolved Hide resolved
@andris9 andris9 merged commit 260b9ad into master Sep 21, 2023
6 checks passed
@andris9 andris9 deleted the ZMS-86-mailboxes branch September 21, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants