Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: cleanup the RunCommand queues on RemoveEnv #25

Merged
merged 4 commits into from
Nov 22, 2023
Merged

src: cleanup the RunCommand queues on RemoveEnv #25

merged 4 commits into from
Nov 22, 2023

Conversation

santigimeno
Copy link
Member

@santigimeno santigimeno commented Nov 16, 2023 •
edited
Loading 

src: change EnvList::promise_tracking_() signature

Pass directly the SharedEnvInst.

src: fix EnvInst::GetCurrent()

Handle the case where the `Environment` is already nullptr.

src: cleanup the RunCommand queues on RemoveEnv

Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

src: fix SetupArrayBufferExports() declaration

Fixes: #26

@santigimeno santigimeno self-assigned this Nov 16, 2023
@santigimeno
src: change EnvList::promise_tracking_() signature
209112a 
Pass directly the SharedEnvInst.

PR-URL: #25
Reviewed-by: Santiago Gimeno <[email protected]>
@santigimeno
src: fix EnvInst::GetCurrent()
6f303c7 
Handle the case where the `Environment` is already nullptr.

PR-URL: #25
Reviewed-by: Santiago Gimeno <[email protected]>
@santigimeno
src: cleanup the RunCommand queues on RemoveEnv
be6aea6 
Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

PR-URL: #25
Reviewed-by: Santiago Gimeno <[email protected]>
@santigimeno
src: fix SetupArrayBufferExports() declaration
f16e228 
PR-URL: #25
Reviewed-by: Santiago Gimeno <[email protected]>
@santigimeno santigimeno force-pushed the santi/fix_shared_envinst_leak branch from 03690a8 to f16e228 Compare November 22, 2023 14:24
@santigimeno santigimeno merged commit f16e228 into node-v20.x-nsolid-v5.x Nov 22, 2023
15 of 18 checks passed
@santigimeno santigimeno deleted the santi/fix_shared_envinst_leak branch November 22, 2023 14:25
trevnorris pushed a commit that referenced this pull request Nov 30, 2023
@santigimeno @trevnorris
src: change EnvList::promise_tracking_() signature
1f2366e 
Pass directly the SharedEnvInst.

PR-URL: #25
Reviewed-by: Santiago Gimeno <[email protected]>
trevnorris pushed a commit that referenced this pull request Nov 30, 2023
@santigimeno @trevnorris
src: fix EnvInst::GetCurrent()
d67a0ba 
Handle the case where the `Environment` is already nullptr.

PR-URL: #25
Reviewed-by: Santiago Gimeno <[email protected]>
trevnorris pushed a commit that referenced this pull request Nov 30, 2023
@santigimeno @trevnorris
src: cleanup the RunCommand queues on RemoveEnv
5e1b2d9 
Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

PR-URL: #25
Reviewed-by: Santiago Gimeno <[email protected]>
trevnorris pushed a commit that referenced this pull request Nov 30, 2023
@santigimeno @trevnorris
src: fix SetupArrayBufferExports() declaration
7e71090 
PR-URL: #25
Reviewed-by: Santiago Gimeno <[email protected]>
trevnorris pushed a commit that referenced this pull request Nov 30, 2023
@santigimeno @trevnorris
src: change EnvList::promise_tracking_() signature
33c8b29 
Pass directly the SharedEnvInst.

PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
trevnorris pushed a commit that referenced this pull request Nov 30, 2023
@santigimeno @trevnorris
src: fix EnvInst::GetCurrent()
2e55267 
Handle the case where the `Environment` is already nullptr.

PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
trevnorris pushed a commit that referenced this pull request Nov 30, 2023
@santigimeno @trevnorris
src: cleanup the RunCommand queues on RemoveEnv
ed78fc6 
Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
trevnorris pushed a commit that referenced this pull request Nov 30, 2023
@santigimeno @trevnorris
src: fix SetupArrayBufferExports() declaration
f6fd580 
PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
trevnorris pushed a commit that referenced this pull request Dec 5, 2023
@santigimeno @trevnorris
src: change EnvList::promise_tracking_() signature
f2fc8ef 
Pass directly the SharedEnvInst.

PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
trevnorris pushed a commit that referenced this pull request Dec 5, 2023
@santigimeno @trevnorris
src: fix EnvInst::GetCurrent()
7649d47 
Handle the case where the `Environment` is already nullptr.

PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
trevnorris pushed a commit that referenced this pull request Dec 5, 2023
@santigimeno @trevnorris
src: cleanup the RunCommand queues on RemoveEnv
21fc1e9 
Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
trevnorris pushed a commit that referenced this pull request Dec 5, 2023
@santigimeno @trevnorris
src: fix SetupArrayBufferExports() declaration
f4d4d46 
PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
trevnorris pushed a commit that referenced this pull request Dec 7, 2023
@santigimeno @trevnorris
src: change EnvList::promise_tracking_() signature
2d187ff 
Pass directly the SharedEnvInst.

PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
trevnorris pushed a commit that referenced this pull request Dec 7, 2023
@santigimeno @trevnorris
src: fix EnvInst::GetCurrent()
5ab8629 
Handle the case where the `Environment` is already nullptr.

PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
trevnorris pushed a commit that referenced this pull request Dec 7, 2023
@santigimeno @trevnorris
src: cleanup the RunCommand queues on RemoveEnv
2dbb826 
Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
trevnorris pushed a commit that referenced this pull request Dec 7, 2023
@santigimeno @trevnorris
src: fix SetupArrayBufferExports() declaration
846637d 
PR-URL: #25
Reviewed-by: Trevor Norris <[email protected]>
@juanarbol juanarbol mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevnorris trevnorris trevnorris approved these changes

Assignees

@santigimeno santigimeno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leak detected when running the tests with ASAN.
2 participants
@santigimeno @trevnorris