-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactored compact flows #7
Conversation
@Olllom I think I fixed the shape bug. I am not perfectly happy with the semantics - so this might need some deeper refactoring in the long run:
-- I am not perfectly sure but it seems to be slower now - but I only checked it on CPU yet anyways and the model will benefit heavily from GPU support. Can you compare to see whether that is true? If it is too slow we have to see whether there are some spurious memory allocations happening from the fix (e.g. as a result from broadcasting). -- I did not merge your docstrings/comments yet. -- Inverses via bisections work again. -- I also changed the |
…nto compact-interval-flows
…nto compact-interval-flows
…nto compact-interval-flows
…nto compact-interval-flows
…nto compact-interval-flows
Compact interval fixes
closing this in favor of its duplicate (#28 ) |
@Olllom