Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter component languages by project type #818

Merged
merged 6 commits into from
Nov 14, 2017
Merged

Filter component languages by project type #818

merged 6 commits into from
Nov 14, 2017

Conversation

bergie
Copy link
Member

@bergie bergie commented Nov 14, 2017

Half-way to solving #206. It would still be nice to have runtime telling what languages they support, as there may be optional ones, like CoffeeScript only working with NoFlo runtimes if the CoffeeScript compiler is installed.

Some examples...

NoFlo:
screenshot 2017-11-14 at 16 20 01
MsgFlo:
screenshot 2017-11-14 at 16 19 48
ImgFlo:
screenshot 2017-11-14 at 16 20 43
Unknown type (all languages listed):
screenshot 2017-11-14 at 16 20 25

@bergie bergie requested a review from jonnor November 14, 2017 15:25
Copy link
Member

@jonnor jonnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bergie
Copy link
Member Author

bergie commented Nov 14, 2017

Minor addition: if you're in a graph, we get the runtime type from the graph instead of the project. This allows creating components properly in a multi-runtime graph.

These two are in the same project:

screenshot 2017-11-14 at 16 41 25

screenshot 2017-11-14 at 16 41 38

@bergie bergie merged commit b6b72d0 into master Nov 14, 2017
@bergie bergie deleted the filter_languages branch November 14, 2017 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants