Merge pull request #3 from tobihille/master

Prevent producing an error if http-request is failing
noglitchyo · Nov 1, 2018 · 3192959 · 3192959
2 parents f5c120c + 20de029
commit 3192959
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/app/code/community/NoGlitchYo/GoogleRecaptcha/Model/Validator.php b/app/code/community/NoGlitchYo/GoogleRecaptcha/Model/Validator.php
@@ -36,6 +36,9 @@ public function validate()
 
         try {
             $data = $this->_request($captchaResponse, $secret);
+            if (empty($data)) {
+                return false;
+            }
         } catch (Exception $e) {
             return false;
         }
@@ -68,10 +71,12 @@ protected function _request($captchaResponse, $secret)
         catch (Zend_Http_Exception $e) {
             Mage::logException($e);
             Mage::getSingleton('customer/session')->addError(Mage::helper('grecaptcha')->__('Unable to validate the reCAPTCHA with Google. Please, retry later.'));
+            return null;
         }
         catch (Exception $e) {
             Mage::logException($e);
             Mage::getSingleton('customer/session')->addError(Mage::helper('grecaptcha')->__('Unable to validate the reCAPTCHA.'));
+            return null;
         }
 
         return $this->_parseResponse($response);