Resolve Issue #582 #692
Resolve Issue #582 #692
Conversation
mariapaolasmnt
commented
Feb 12, 2025
mariapaolasmnt
commented
- As Data browser user I want a better UI for the filter set, to what exactly I have to click to set one or more filters. #582
* main: (112 commits) changing field order adapting field changes changing field order adapting field changes Use up-to-date reuse tool in GitHub action Convert dep5 file to REUSE.toml fix pavement select option Remove disabled dataset filter button fixing ShieldingPostInFrontOfStation Improve map view performance by rendering OverviewCardItem elements only if map is not visible Update package-lock.json Increase z-index for active layer and marker Open record detail from map view in same tab Use pinia store to improve map-view implementation Implement URL state for map view Fix bug where map-view records data was not loaded when map-view was closed and reopened Style close-button for map view dialog Increase limit of records that are loaded from timeseries API Fix bug where an undefined value was accessed Remove memoize from meta data fetching and configure stale time for query instead ... # Conflicts: # databrowser/src/pages/datasets/overview/OverviewListPage.vue
databrowser/src/domain/datasets/ui/tableView/filter/tableFilterStore.ts
Outdated
Show resolved
Hide resolved
|
is this PR ready to merge? |
yes, the PR is ready to merge |
|
@gappc can you please do the final check and notify @RudiThoeni when you are done? |
|
@sseppi some issues need to be resolved, otherwise we introduce bugs with this PR. @mariapaolasmnt please take a look at the latest comments, specially about the filters |
| tableFilters.value = tableFiltersSelected.map(filter => ({ | ||
| ...filter | ||
| })); |
There was a problem hiding this comment.
I'm still not sure what you're trying to accomplish here. In effect, what this code does is, that it generates a new pointer on a new array of objects, where each object gets a new pointer to its contents. Is this really necessary here? Because in that case, maybe a structuredClone would be more appropriate and easier to understand.
If it's not necessary, I would just assign tableFiltersSelected to tableFilters.value.
Or am I missing something?
| tableFilters.some((filter) => | ||
| ['isnull', 'isnotnull'].includes(filter.operator) |
There was a problem hiding this comment.
I think this works only for datasets from the content API (previously named tourism API), because the filters isnull and isnotnull exist only in the content API
Please take a look at
| @@ -61,7 +61,7 @@ export const useTableFilterStore = defineStore('tableFilterStore', () => { | |||
| if (propertyPath != null) { | |||
| tableFilters.value = [ | |||
| ...tableFilters.value, | |||
| { propertyPath, title, operator: 'eq', value: '' }, | |||
| { propertyPath, title, operator: 'like', value: '' }, | |||
There was a problem hiding this comment.
I think this works only for datasets from the content API (previously named tourism API), because the filter like exists only in the content API
Please take a look at
