fix: correct batch inversion function #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
kashbrti
reviewed
Feb 3, 2025
src/fns/unconstrained_ops.nr
Outdated
| accumulator = __mul::<_, MOD_BITS>(params, accumulator, x[idx]); | ||
| result[idx] = T0; | ||
| } | ||
| assert(__mul::<_, MOD_BITS>(params, T0, x[idx]) == __one::<N>()); |
There was a problem hiding this comment.
added an assertion for easier debugging later if something goes wrong, it wasn't showing the call stack properly.
kashbrti
reviewed
Feb 3, 2025
| result[idx] = T0; | ||
| } | ||
| assert(__mul::<_, MOD_BITS>(params, T0, x[idx]) == __one::<N>()); | ||
| result = result.push_front(T0); |
There was a problem hiding this comment.
The order was reversed, so we should push things to the front instead of the back
There was a problem hiding this comment.
removed it in a later commit
kashbrti
reviewed
Feb 3, 2025
| assert(__mul::<_, MOD_BITS>(params, T0, x[idx]) == __one::<N>()); | ||
| result = result.push_front(T0); | ||
| } else { | ||
| result = result.push_front([0; N]); |
There was a problem hiding this comment.
result.push_front does not update the slice, and we should rather do result = result.push_front()
kashbrti
approved these changes
Feb 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This got broken in #79
Additional Context
PR Checklist*
cargo fmton default settings.