issue: nargo is complaining about trait visibility not matching the import #92
+194
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashbrti
commented
Jan 7, 2025
| @@ -18,6 +18,6 @@ pub(crate) mod utils; | |||
| pub use bignum::BigNum; | |||
| pub use bignum::BigNumTrait; // So that external code can operate on a generic BigNum, `where BigNum: BigNumTrait`. | |||
| pub use runtime_bignum::RuntimeBigNum; | |||
|
|
|||
| pub use runtime_bignum::RuntimeBigNumTrait; | |||
There was a problem hiding this comment.
I've imported the trait here. but the I'm getting an error.
the BignumTrait is imported here as well.
There was a problem hiding this comment.
pub use is saying that you want to reexport RuntimeBigNumTrait so it's visible outside of the crate. As runtime_bignum::RuntimeBigNumTraitispub(crate)` then you're increasing the visibility of this trait, which isn't allowed.
There was a problem hiding this comment.
changed the trait to a pub instead of pub(crate). The error disappeared but the warning is still around.
There was a problem hiding this comment.
You mean?
warning: Visibility is ignored on a trait method
┌─ src/runtime_bignum.nr:69:5
│
69 │ pub fn __udiv_mod(self, divisor: Self) -> (Self, Self);
│ ---
│
There was a problem hiding this comment.
This is expected as those modifiers don't mean anything on trait methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm trying to fix the trait visibility warnings in bignum.
For the
RuntimeBignumTraitI'm getting an error when importing the trait inlib.nrProblem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.