Merge branch 'master' into tf/recursive-onchain

* master: (216 commits)
  chore(docs): address visibility issues in docs (#3643)
  chore: type formatting (#3618)
  fix: Restrict fill_internal_slices pass to acir functions (#3634)
  chore(docs): docs for v0.19.4 (#3601)
  feat: aztec-packages (#3626)
  chore: Move tests to the correct root (#3633)
  feat: Implement integer printing (#3577)
  fix: corrected the formatting of error message parameters in index out of bounds error (#3630)
  chore: Update ACIR artifacts (#3619)
  chore(debugger): Run debugger REPL in thread (#3611)
  chore: remove deprecated method (#3625)
  feat: Implement raw string literals (#3556)
  fix: docker builds (#3620)
  feat: Copy on write optimization for brillig (#3522)
  chore: separate methods in `dc_crate` into their own modules (#3585)
  feat: add special case for boolean AND in acir-gen (#3615)
  chore: Update ACIR artifacts (#3614)
  chore: remove `get_number_sequence` foreign calls (#3613)
  feat: Add package version to Nargo.toml metadata (#3427)
  chore(docs): Links to Aztec docs from errors (#3423)
  ...

.dockerignore

@@ -0,0 +1,22 @@
+Dockerfile*
+.dockerignore
+
+packages
+**/package.tgz
+**/target
+**/node_modules
+**/outputs
+
+# Source resolver
+compiler/source-resolver/lib
+compiler/source-resolver/lib-node
+
+# Noir.js
+tooling/noir_js/lib
+
+# Wasm build artifacts
+compiler/wasm/nodejs
+compiler/wasm/web
+tooling/noirc_abi_wasm/nodejs
+tooling/noirc_abi_wasm/web
+tooling/noir_js/lib

.github/actions/docs/build-status/script.sh

@@ -18,11 +18,11 @@ while [[ "$DEPLOY_STATUS" != "ready" && $COUNT -lt $MAX_RETRIES ]]; do
         exit 0
     elif [[ "$DEPLOY_STATUS" == "error" ]]; then
         echo "deploy_status=failure" >> $GITHUB_OUTPUT
-        exit 0
+        exit 1
     fi
 
     echo "Deploy still running. Retrying..."
 done
 
 echo "deploy_status=failure" >> $GITHUB_OUTPUT
-exit 0
+exit 1

.github/pull_request_template.md

@@ -1,37 +1,23 @@
 # Description
 
-<!-- Thanks for taking the time to improve Noir! -->
-<!-- Please fill out all fields marked with an asterisk (*). -->
-
 ## Problem\*
 
-<!-- Describe the problem this Pull Request (PR) resolves / link to the GitHub Issue that describes the problem. -->
-
 Resolves <!-- Link to GitHub Issue -->
 
 ## Summary\*
 
-<!-- Describe the changes in this PR. -->
-<!-- Supplement code examples and highlight breaking changes, if applicable. -->
-
-## Documentation
-
-- [ ] This PR requires documentation updates when merged.
 
-  <!-- If checked, check one of the following: -->
 
-  - [ ] I will submit a noir-lang/docs PR.
-
-  <!-- Submit a PR on https://github.com/noir-lang/docs. Thank you! -->
+## Additional Context
 
-  - [ ] I will request for and support Dev Rel's help in documenting this PR.
 
-  <!-- List / highlight what should be documented. -->
-  <!-- Dev Rel will reach out for clarifications when needed. Thank you! -->
 
-## Additional Context
+## Documentation\*
 
-<!-- Supplement further information if applicable. -->
+Check one:
+- [ ] No documentation needed.
+- [ ] Documentation included in this PR.
+- [ ] **[Exceptional Case]** Documentation to be submitted in a separate PR.
 
 # PR Checklist\*
 

.github/workflows/auto-pr-rebuild-script.yml

@@ -1,13 +1,45 @@
 name: Rebuild ACIR artifacts
 
 on:
+  pull_request:
   push:
     branches:
       - master
 
 jobs:
+  check-artifacts-requested:
+    name: Check if artifacts should be published
+    runs-on: ubuntu-22.04
+    outputs:
+      publish: ${{ steps.check.outputs.result }}
+
+    steps:
+      - name: Check if artifacts should be published
+        id: check
+        uses: actions/github-script@v6
+        with:
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          script: |
+            const { REF_NAME } = process.env;
+            if (REF_NAME == "master") {
+              console.log(`publish = true`)
+              return true;
+            }
+
+            const labels = context.payload.pull_request.labels.map(label => label.name);
+            const publish = labels.includes('publish-acir');
+
+            console.log(`publish = ${publish}`)
+            return publish;
+          result-encoding: string
+        env:
+          REF_NAME: ${{ github.ref_name }}
+
   build-nargo:
+    name: Build nargo binary
+    if:  ${{ needs.check-artifacts-requested.outputs.publish == 'true' }}
     runs-on: ubuntu-22.04
+    needs: [check-artifacts-requested]
     strategy:
       matrix:
         target: [x86_64-unknown-linux-gnu]
@@ -17,7 +49,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup toolchain
-        uses: dtolnay/rust-toolchain@1.66.0
+        uses: dtolnay/rust-toolchain@1.71.1
 
       - uses: Swatinem/rust-cache@v2
         with:
@@ -42,12 +74,13 @@ jobs:
           retention-days: 3
 
   auto-pr-rebuild-script:
+    name: Rebuild ACIR artifacts
     needs: [build-nargo]
     runs-on: ubuntu-latest
 
     steps:
       - name: Check out code
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
 
       - name: Download nargo binary
         uses: actions/download-artifact@v3
@@ -66,15 +99,23 @@ jobs:
           git config --local user.email [email protected]
 
       - name: Run rebuild script
-        working-directory: tooling/nargo_cli/tests
+        working-directory: test_programs
         run: |
           chmod +x ./rebuild.sh
           ./rebuild.sh
 
+      - name: Upload ACIR artifacts
+        uses: actions/upload-artifact@v3
+        with:
+          name: acir-artifacts
+          path: ./test_programs/acir_artifacts
+          retention-days: 10
+
       - name: Check for changes in acir_artifacts directory
         id: check_changes
+        if: ${{ github.ref_name }} == "master"
         run: |
-          git diff --quiet tooling/nargo_cli/tests/acir_artifacts/ || echo "::set-output name=changes::true"
+          git diff --quiet test_programs/acir_artifacts/ || echo "::set-output name=changes::true"
           
       - name: Create or Update PR
         if: steps.check_changes.outputs.changes == 'true'
@@ -84,6 +125,6 @@ jobs:
           commit-message: "chore: update acir artifacts"
           title: "chore: Update ACIR artifacts"
           body: "Automatic PR to update acir artifacts"
-          add-paths: tooling/nargo_cli/tests/acir_artifacts/*.gz
+          add-paths: test_programs/acir_artifacts/*.gz
           labels: "auto-pr"
           branch: "auto-pr-rebuild-script-branch"

.github/workflows/build-aztec-feature-flag.yml

@@ -0,0 +1,45 @@
+name: Build with aztec feature flag
+
+on:
+  pull_request:
+  merge_group:
+  push:
+    branches:
+      - master
+
+# This will cancel previous runs when a branch or PR is updated
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  build-aztec-feature-flag:
+    name: Test on ${{ matrix.os }}
+    runs-on: ${{ matrix.runner }}
+    timeout-minutes: 30
+
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - os: ubuntu
+            runner: ubuntu-latest
+            target: x86_64-unknown-linux-gnu
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+
+      - name: Setup toolchain
+        uses: dtolnay/[email protected]
+        with:
+          targets: ${{ matrix.target }}
+
+      - uses: Swatinem/rust-cache@v2
+        with:
+          key: ${{ matrix.target }}
+          cache-on-failure: true
+          save-if: ${{ github.event_name != 'merge_group' }}
+
+      - name: Build with feature flag
+        run: cargo build --features="noirc_driver/aztec"