Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check for errors in formatter tests #3594

Closed
wants to merge 4 commits into from

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

We're getting a lot of warnings in CI based on not using the errors variable. I've then added a check that it's an empty array.

https://github.com/noir-lang/noir/actions/runs/7009687704/job/19068675333#step:5:39

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

tooling/nargo_fmt/build.rs Outdated Show resolved Hide resolved
@TomAFrench TomAFrench force-pushed the tf/fix-compilation-warning branch from 3b34667 to 9ab8f5e Compare November 27, 2023 20:22
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no point in asserting that is empty or only composed of warnings, why not rename errors to _errors?

@TomAFrench TomAFrench requested a review from jfecher December 14, 2023 14:58
@TomAFrench TomAFrench closed this Dec 18, 2023
@TomAFrench TomAFrench deleted the tf/fix-compilation-warning branch January 14, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants