Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix wrapping_add example code in docs #3972

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

arihantbansal
Copy link
Contributor

Description

Problem*

Documentation has a slight typo wrt wrapping_add function which takes two params, x and y separately instead of the addition of the two as that would defeat the purpose of it.

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. LGTM

For future readers of this PR, we generally have a policy against merging "trivial" PRs against the docs due to wanting to discourage airdrop farmers sucking up the time of the core team. Despite this being a one-line change, this is an actual issue with the docs where code examples will not run so I don't think it falls under that category.

@TomAFrench TomAFrench changed the title Fix wrapping_add example code chore: Fix wrapping_add example code in docs Jan 8, 2024
@TomAFrench TomAFrench added this pull request to the merge queue Jan 8, 2024
Merged via the queue into noir-lang:master with commit 063c396 Jan 8, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants