Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: character_to_line_offset doc and test #3974

Merged
merged 3 commits into from
Jan 8, 2024
Merged

chore: character_to_line_offset doc and test #3974

merged 3 commits into from
Jan 8, 2024

Conversation

kobyhallx
Copy link
Contributor

Description

Problem*

Resolves

Add comment for character_to_line_offset and a unit test #3756

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kobyhallx kobyhallx requested a review from TomAFrench January 8, 2024 10:24
@kobyhallx kobyhallx changed the title Kh-ch2offset_test_3756 chore: character_to_line_offset doc and test Jan 8, 2024
@TomAFrench TomAFrench enabled auto-merge January 8, 2024 11:26
@TomAFrench TomAFrench added this pull request to the merge queue Jan 8, 2024
Merged via the queue into master with commit 2dcf019 Jan 8, 2024
30 checks passed
@TomAFrench TomAFrench deleted the kh-ch2offset_test_3756 branch January 8, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobyhallx @TomAFrench