chore: refactor foreign call executors #6659
Merged
+601
−510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
approved these changes
Dec 2, 2024
aakoshh
reviewed
Dec 2, 2024
| assert!(ForeignCall::lookup(&mock_oracle_name).is_none()); | ||
| let id = self.last_mock_id; | ||
| self.mocked_responses.push(MockedCall::new(id, mock_oracle_name)); | ||
| self.last_mock_id += 1; |
There was a problem hiding this comment.
It's not obvious to me why the mocks aren't stored in a BTreeMap indexed by ID. I looks like we won't have repeated IDs; I thought there might be multiple single-use responses lined up for the same ID, but not sure that's a use case.
There was a problem hiding this comment.
Our testing of mocked oracle calls is woefully incomplete atm so this may not be the ideal implementation. Let's handle this in a followup.
aakoshh
reviewed
Dec 2, 2024
|
|
||
| #[derive(Debug)] | ||
| pub(super) struct RPCForeignCallExecutor { | ||
| /// A randomly generated id for this `DefaultForeignCallExecutor`. |
There was a problem hiding this comment.
Should be RPCForeignCallExecutor
aakoshh
reviewed
Dec 2, 2024
| /// A randomly generated id for this `DefaultForeignCallExecutor`. | ||
| /// | ||
| /// This is used so that a single `external_resolver` can distinguish between requests from multiple | ||
| /// instantiations of `DefaultForeignCallExecutor`. |
TomAFrench
added a commit
that referenced
this pull request
Dec 2, 2024
…compiler * master: chore: update noir-bench-report version (#6675) fix: Prevent hoisting binary instructions which can overflow (#6672) feat(ssa): Hoisting of array get using known induction variable maximum (#6639) feat: better error message when trying to invoke struct function field (#6661) feat: add memory report into the CI (#6630) feat: allow ignoring test failures from foreign calls (#6660) chore: refactor foreign call executors (#6659) fix: correct signed integer handling in `noirc_abi` (#6638) fix: allow multiple `_` parameters, and disallow `_` as an expression you can read from (#6657) feat: allow filtering which SSA passes are printed (#6636) fix: use correct type for attribute arguments (#6640) fix: always return an array of `u8`s when simplifying `Intrinsic::ToRadix` calls (#6663) feat(ssa): Option to set the maximum acceptable Brillig bytecode increase in unrolling (#6641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This is a refactor to make it easier to implement #6643. We're probably going to want to have a new foreign call handler which we use for testing so I'd like to break these up a bit.
See #6643 (comment)
As a bonus it becomes way easier to add a bunch of tests for how we deal with mocked foreign calls and external resolvers, etc.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.