Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): print protocol circuits gate counts #6832

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Peak Memory Sample

Program Peak Memory
keccak256 78.15M
workspace 122.44M
regression_4709 423.26M
ram_blowup_regression 1.58G
private-kernel-tail 206.67M
private-kernel-reset 720.25M
private-kernel-inner 291.85M
parity-root 171.68M

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Compilation Report

Program Compilation Time %
sha256_regression 1.461s 9%
regression_4709 0.832s 4%
ram_blowup_regression 15.688s 3%
rollup-root 4.600s 26%
rollup-block-merge 3.798s 5%
rollup-base-public 128.588s 12%
rollup-base-private 100.171s 2%
private-kernel-tail 0.997s -6%
private-kernel-reset 7.513s 6%
private-kernel-inner 2.238s -1%
parity-root 0.783s 8%
noir-contracts 87.734s 0%

@TomAFrench TomAFrench mentioned this pull request Dec 17, 2024
5 tasks
* master: (47 commits)
  chore: delete a bunch of dead code from `noirc_evaluator` (#6939)
  feat: require trait function calls (`Foo::bar()`) to have the trait in scope (imported) (#6882)
  chore: Bump arkworks to version `0.5.0` (#6871)
  feat(ssa): Hoist add and mul binary ops using known induction variables (#6910)
  chore: fix warning (#6927)
  chore(ci): Memory reports for execution (#6907)
  chore: use ssa parser in flattening pass tests (#6868)
  feat(LSP): suggest trait methods from where clauses (#6915)
  feat: warn on trait method visibility (#6923)
  feat!: Switch to using `jsonrpsee` for foreign calls; refactor `run_test`; foreign call layering (#6849)
  chore: add rollup circuits to memory reports (#6897)
  chore: remove unused dependency (#6922)
  chore: add if/loop tip (separate from no-predicate #5657) (#6806)
  chore: move implementation of print foreign call into `nargo` (#6865)
  chore: document format strings (#6920)
  chore: add `rollup_root` and `rollup_block_merge` to tracked protocol circuits (#6903)
  fix: consistent file_id across installation paths (#6912)
  fix: bigint builtins are foreigns (#6892)
  fix: remove unnecessary cast in bit-shift (#6890)
  chore: Release Noir(1.0.0-beta.1) (#6622)
  ...
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Execution Report

Program Execution Time %
sha256_regression 0.615s 2%
regression_4709 0.420s 2%
ram_blowup_regression 3.916s 0%
rollup-root 2.174s -1%
rollup-block-merge 2.171s 3%
rollup-base-public 35.595s 2%
rollup-base-private 31.437s -1%
private-kernel-tail 0.746s -2%
private-kernel-reset 2.210s 1%
private-kernel-inner 1.255s 1%
parity-root 0.531s -2%

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Compilation Memory Report

Program Peak Memory
keccak256 78.48M
workspace 123.35M
regression_4709 422.91M
ram_blowup_regression 1.58G
rollup-base-public 10.47G
rollup-base-private 6.57G
private-kernel-tail 201.79M
private-kernel-reset 717.06M
private-kernel-inner 291.86M
parity-root 172.13M

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Execution Memory Report

Program Peak Memory
keccak256 74.61M
workspace 123.42M
regression_4709 315.92M
ram_blowup_regression 512.47M
rollup-base-public 3.05G
rollup-base-private 2.97G
private-kernel-tail 181.16M
private-kernel-reset 255.25M
private-kernel-inner 214.35M
parity-root 155.86M

@TomAFrench
Copy link
Member Author

We can't just push the protocol circuits through the bb gates as they all need various arguments to be provided. I think its cleanest for us to just have opcode counts for these until bb handles this cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant